-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional properties to make knots s9pk better than core #17
Conversation
Options added: - Max Mempool Size in MB - Current Mempool Usage in MB and as a percentage - Mempool Transaction Count - progress to next halving - Current total supply of Bitcoin based on issuance schedule (may be very slightly inaccuate compared to gettxoutsetinfo but is great for monitoring at a glance without needing to wait) I have also made and tested this to ensure it works flawlessly. s9pk added in comments
Here is the s9pk as a release in my knots fork, feel free to use it: https://github.com/j34g/knots-startos/releases/tag/v27.0.1.1 Note that due to a bug in startos when sideloading you may get the endless 'stopping service' error and will need to restart your server due to the ~1 added in the manifest of the s9pk |
Reasons 'total bitcoin supply' may not be exactly the same as gettxoutinfo:
However overall this is a great at a glance metric imo to keep a check on things (with a fraction of a percent difference), especially since gettxoutsetinfo is resource and time intensive. |
Wow, thanks for the amazing work! We will review this and merge this if it's ok. |
thanks again! |
Would you consider making an updated release and pushing it to the community registry? |
Needs to be in line with the next Core release because of StartOS weirdness until 0.3.6 |
And if we make a release with the same version number? |
Then it won't be annoying for users getting prompted with updates, but to install the new release they will have to sideload it or eneable "dev mode" to "reinstall" Knots (rather than uninstall and install which loses service data/blockchain etc) |
With the same version number startOS wont update things like the instructions file and stuff because it only looks for new versions of those things with a new version number, hence why I made the version 27.0.1.1 on my fork so startos would recognise all changes |
well lets wait for the next release then :/ |
I don't think that's a risk. I'm going to confirm what @j34g said about the version number and then maybe we can do a release. |
This is lower than current version (27.1.0) - that'd stop StartOS from prompting for updates but also require that users downgrade. This is possible but seems like a mistake? |
My bad, I typed it wrong in that comment it is actually version: 27.1.0.1 in my s9pk - https://github.com/j34g/knots-startos/blob/knots/manifest.yaml#L3 |
Yeah, the issue just remains that it'd be higher than what's on the regular marketplace for Bitcoin Core so users that have the Community Marketplace added (I think it is by default) will be prompted to upgrade Bitcoin (and probably accidentally end up on Knots). |
You can keep it the same version instead to avoid that problem. Until 0.3.6, Core and Knots must move in lock step version wise to avoid users upgrading without realizing they're switching from Core to Knots or the reverse. |
Oh right because they have the same id, I see the issue now. Although I don't think you get prompted for updates that are on the community marketplace unless you switch to it manually or have Dev tools enabled (i'm not sure about this though). |
The Community registry is a default registry, so you will see updates by default in the Updates tab. Dev tools only needed for Alpha/Beta registries to show there. |
Definitely the consolidated one! |
Properties added:
I have also made and tested this to ensure it works flawlessly.
s9pk added in comments