Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printStackTrace in ElementParser.java #162

Open
jarekkosowski opened this issue Feb 1, 2021 · 0 comments
Open

printStackTrace in ElementParser.java #162

jarekkosowski opened this issue Feb 1, 2021 · 0 comments

Comments

@jarekkosowski
Copy link

Hello,

One small request. Could you please remove e.printStackTrace() from https://github.com/RestComm/jdiameter/blob/master/core/jdiameter/impl/src/main/java/org/jdiameter/client/impl/parser/ElementParser.java

line: 328

catch (Exception e) {
  e.printStackTrace();
  logger.debug("Error during encode avps", e);
}

I assume it shouldn't be there. And maybe log this exception with higher level:)

Regards,
Jarek
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jarekkosowski