Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isVis based on Field annotation #80

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix isVis based on Field annotation #80

wants to merge 5 commits into from

Conversation

yibeichan
Copy link
Contributor

  1. if "@readonly" is in Field annotation, set isVis: False
  2. if "@CALCTEXTis inField annotation, set isVis: False`, we also update compute list
  3. also changed csv.Reader to pandas
  4. added some tests, passed

TODO:
we may want to update the following (line 305) as well, I need more time to figure out the logic here

elif field_type in COMPUTE_LIST:
    rowData["ui"]["readonlyValue"] = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yibeichan