From 1c879ae50de2c05f27927cfe5b3a205b961c29f5 Mon Sep 17 00:00:00 2001 From: Release-Candidate Date: Sun, 16 Jul 2023 10:21:12 +0200 Subject: [PATCH] Change Node versions in workflows, 14 does not work Signed-off-by: Release-Candidate --- .github/workflows/lint.yml | 64 +++++++++++++++++++------------------- .github/workflows/test.yml | 51 +++++++++++++++--------------- 2 files changed, 57 insertions(+), 58 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 63f7ac4..134d294 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -10,37 +10,37 @@ name: Lint on: - push: - branches: ["main"] - pull_request: - branches: ["main"] + push: + branches: ["main"] + pull_request: + branches: ["main"] jobs: - eslint: - strategy: - matrix: - os: [ubuntu-latest] - node-version: [14.x, 16.x, 18.x] - - runs-on: ${{ matrix.os }} - - steps: - - name: Checkout - uses: actions/checkout@v3 - - - name: Setup Node - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} - - - name: Eslint - run: | - yarn --ignore-engines install --dev - yarn --ignore-engines lint-github - - - name: Annotate Code Linting Results - uses: ataylorme/eslint-annotate-action@v2 - if: ${{ always() }} - with: - repo-token: "${{ secrets.GITHUB_TOKEN }}" - report-json: "eslint_report.json" + eslint: + strategy: + matrix: + os: [ubuntu-latest] + node-version: [16.x, 18.x, 20.x] + + runs-on: ${{ matrix.os }} + + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Node + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + + - name: Eslint + run: | + yarn --ignore-engines install --dev + yarn --ignore-engines lint-github + + - name: Annotate Code Linting Results + uses: ataylorme/eslint-annotate-action@v2 + if: ${{ always() }} + with: + repo-token: "${{ secrets.GITHUB_TOKEN }}" + report-json: "eslint_report.json" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f88beb7..d350561 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,34 +7,33 @@ # # ============================================================================== - name: Test on: - push: - branches: ["main"] - pull_request: - branches: ["main"] + push: + branches: ["main"] + pull_request: + branches: ["main"] jobs: - tests: - strategy: - matrix: - os: [ubuntu-latest] - node-version: [16.x, 18.x] - - runs-on: ${{ matrix.os }} - - steps: - - name: Checkout - uses: actions/checkout@v3 - - - name: Setup Node - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} - - - name: Run Tests - run: | - yarn --ignore-engines install --dev - xvfb-run -a yarn --ignore-engines test + tests: + strategy: + matrix: + os: [ubuntu-latest] + node-version: [16.x, 18.x, 20.x] + + runs-on: ${{ matrix.os }} + + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Node + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + + - name: Run Tests + run: | + yarn --ignore-engines install --dev + xvfb-run -a yarn --ignore-engines test