create to_json function #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo
…rai-sdk-python into nsh-output-to-json merge
larf311
reviewed
Mar 30, 2022
| @@ -0,0 +1,97 @@ | |||
|
|
|||
There was a problem hiding this comment.
I believe this file needs the license as well.
bradlo
requested changes
Mar 30, 2022
railib/utilities.py
Outdated
| ''' | ||
| for i in range(len(keys) - 1): | ||
| key = keys[i] | ||
| nextValue = {} if type(keys[i+1]) is str else [] |
There was a problem hiding this comment.
python does not use camelCase for identifiers
There was a problem hiding this comment.
all variables now are snake_case 👍
examples/show_json.py
Outdated
| @@ -0,0 +1,42 @@ | |||
| # Copyright 2021 RelationalAI, Inc. | |||
There was a problem hiding this comment.
wrong year in copyright header.
|
can we merge this? |
|
No, I think we were going to close this as I believe @bradlo had something else in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
add new function "to_json" inside new file "utilities.py"