Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/fix some tests, plus some cleanup and formatting #1

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Add/fix some tests, plus some cleanup and formatting #1

merged 6 commits into from
Sep 18, 2023

Conversation

zengjian-hu-rai
Copy link
Contributor

Add two simple tests per suggestion from @chriscoey

chriscoey
chriscoey approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@chriscoey chriscoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Jian!

@zengjian-hu-rai
Copy link
Contributor Author

Looks good, thanks Jian!

thanks, but not sure why two tests are failing. attempted to fix with issetequal() but still not working. all tests are passing on my local.

Test Summary: | Pass Total Time
SolverAPI | 43 43 0.9s
test | 43 43
test/solve_tests.jl | 43 43
solve | 7 7 0.5s
feas_range | 1 1 0.1s
min_range | 1 1 0.0s
tiny_min | 1 1 0.0s
tiny_feas | 1 1 0.1s
tiny_infeas | 1 1 0.1s
simple_lp | 1 1 0.0s
n_queens | 1 1 0.1s
print | 6 6 0.0s
validate | 30 30 0.0s
feas_with_obj | 2 2 0.0s
min_no_obj | 2 2 0.0s
unsupported_sense | 2 2 0.0s
obj_len_greater_than_1 | 2 2 0.0s
incorrect_range_num_params | 2 2 0.0s
incorrect_range_step_not_1 | 2 2 0.0s
vars_is_not_str | 2 2 0.0s
vars_is_not_arr | 2 2 0.0s
objs_is_not_arr | 2 2 0.0s
cons_is_not_arr | 2 2 0.0s
missing_vars | 2 2 0.0s
missing_cons | 2 2 0.0s
missing_objs | 2 2 0.0s
missing_sense | 2 2 0.0s
missing_version | 2 2 0.0s

zengjian-hu-rai and others added 3 commits September 10, 2023 21:18
@zengjian-hu-rai
Revert "replace = by issetequal"
f90a781 
This reverts commit b365961.
@chriscoey
fix broken tests by not printing MOF; improve readability of code in …
f62dab1 
…some places and add JuliaFormatter options file for consistency
@chriscoey
minor doc fixes
de2ca2c
@chriscoey chriscoey changed the title add more tests with >1 variables Add/fix some tests, plus some cleanup and formatting Sep 12, 2023
@chriscoey chriscoey marked this pull request as draft September 12, 2023 20:46
@chriscoey
Copy link
Member

chriscoey commented Sep 12, 2023 •
edited
Loading

after this, to run JuliaFormatter, you just do format(".") (it uses the new JuliaFormatter.toml to keep things consistent). I added a FormatCheck CI run to check the format before merging.

@chriscoey chriscoey marked this pull request as ready for review September 18, 2023 22:38
@chriscoey
Copy link
Member

Sorry to squeeze in multiple changes in one PR - got a little carried away 😄

@chriscoey chriscoey merged commit d4b836f into main Sep 18, 2023
5 checks passed
@chriscoey chriscoey deleted the zhu-add-more-tests branch September 18, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscoey chriscoey chriscoey approved these changes

@bachdavi bachdavi Awaiting requested review from bachdavi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zengjian-hu-rai @chriscoey