Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup by checking the page only when necessary; Logging update. #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mfalesni
Copy link
Contributor

@mfalesni mfalesni commented May 24, 2017

Basically, up until now widgetastic executed the ensure_page_safe before EVERY element lookup. Now it does it only if it hits an error.

Also added some post-action ensure_page_safe calls. That should reduce the incidence of the repeated lookup.

  • some logging improvements and touches here and there ...

Ran some automation with this branch and it worked well.

This should probably become V0.7.0

@coveralls
Copy link

coveralls commented May 24, 2017

Coverage Status

Coverage increased (+0.03%) to 86.456% when pulling 7743689 on faster-interactions into d0a8a8c on master.

@mfalesni mfalesni requested a review from psav May 24, 2017 15:59
@psav
Copy link
Member

psav commented May 24, 2017

First pass looks good

@coveralls
Copy link

coveralls commented May 25, 2017

Coverage Status

Coverage increased (+0.4%) to 86.871% when pulling a2fc752 on faster-interactions into d0a8a8c on master.

@coveralls
Copy link

coveralls commented May 25, 2017

Coverage Status

Coverage increased (+0.3%) to 86.762% when pulling 7d7a4e6 on faster-interactions into d0a8a8c on master.

@coveralls
Copy link

coveralls commented May 29, 2017

Coverage Status

Coverage increased (+0.4%) to 86.78% when pulling b9a8689 on faster-interactions into d0a8a8c on master.

@mfalesni mfalesni changed the title Initial stab at faster interactions - unit tests pass Speedup by checking the page only when necessary; Logging update. Jun 1, 2017
@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage increased (+0.4%) to 86.78% when pulling 351196e on faster-interactions into d0a8a8c on master.

@mfalesni mfalesni force-pushed the faster-interactions branch 2 times, most recently from 3b07b9f to f39ca61 Compare July 4, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants