-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup by checking the page only when necessary; Logging update. #30
Open
mfalesni
wants to merge
4
commits into
main
Choose a base branch
from
faster-interactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass looks good |
mfalesni
force-pushed
the
faster-interactions
branch
from
June 1, 2017 12:02
b9a8689
to
351196e
Compare
mfalesni
changed the title
Initial stab at faster interactions - unit tests pass
Speedup by checking the page only when necessary; Logging update.
Jun 1, 2017
mfalesni
force-pushed
the
faster-interactions
branch
2 times, most recently
from
July 4, 2017 15:21
3b07b9f
to
f39ca61
Compare
mfalesni
force-pushed
the
faster-interactions
branch
from
July 13, 2017 10:05
f39ca61
to
f35323a
Compare
mfalesni
force-pushed
the
faster-interactions
branch
from
August 16, 2017 13:05
f35323a
to
d537b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, up until now widgetastic executed the ensure_page_safe before EVERY element lookup. Now it does it only if it hits an error.
Also added some post-action ensure_page_safe calls. That should reduce the incidence of the repeated lookup.
Ran some automation with this branch and it worked well.
This should probably become V0.7.0