Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer #43

Open
ShiranHi opened this issue Nov 22, 2022 · 5 comments
Open

Footer #43

ShiranHi opened this issue Nov 22, 2022 · 5 comments

Comments

@ShiranHi
Copy link

ShiranHi commented Nov 22, 2022

The social icon color in the footer should be white #FFFFFF instead of blue.
No color change when hovering, just show a hand pointer.

image

@bennypowers
@ShiranHi
Copy link
Author

ShiranHi commented Nov 22, 2022

  1. Let's make the titles "המוצרים שלנו" and "רד האט" and ״צרו קשר״ with bold text.
  2. Maybe we can write all about Red Hat (third column) to be in a box, something similar to the PF's footer , and add them the social icons too.
  3. The bottom gray icon and the text are not aligned in the black background.

image

@ShiranHi
Copy link
Author

Consider making some changes to organize the footer:
image

@bennypowers
Copy link
Member

we're somewhat limited in what we can do with the footer, since the design is basically set. I believe we can change the contents of the columns in the main part of the footer though. cc @coreyvickery

@coreyvickery
Copy link

@ShiranHi There is an example of a footer in Hebrew on the page below under the Behavior heading, just scroll down about 30% of the page. Would that work for you? If so, @bennypowers how would @ShiranHi implement the Hebrew version of our new footer?

https://ux.redhat.com/components/footer/

@ShiranHi
Copy link
Author

ShiranHi commented Dec 1, 2022

@coreyvickery I've never saw this one, thanks for pointing this out :) Let's use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants