Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenZeppelin, change tests to expect Errors instead of revert strings #234

Open
edmundedgar opened this issue Feb 16, 2024 · 0 comments
Open

Update OpenZeppelin, change tests to expect Errors instead of revert strings #234

edmundedgar opened this issue Feb 16, 2024 · 0 comments
Labels
code-quality Things that are good for general code quality purposes but don't affect functionality not-mvp-blocker Doesn't necessarily need to be addressed to ship something

Comments

@edmundedgar
Copy link
Contributor

It looks like the recent versions of the OpenZeppelin Initializable lib (and probably others) use solidity errors instead of revert strings, which is consistent with what we and polygon do. Check if the latest version is audited, and if so update to the latest version and change our tests to expect errors.

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/utils/Initializable.sol
@edmundedgar edmundedgar added not-mvp-blocker Doesn't necessarily need to be addressed to ship something code-quality Things that are good for general code quality purposes but don't affect functionality labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Things that are good for general code quality purposes but don't affect functionality not-mvp-blocker Doesn't necessarily need to be addressed to ship something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edmundedgar