fix: cannot download other formats #351
Conversation
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 41% smaller than the GitHub diff.
|
|
|
This looks safe to merge already, even before we merge ReadAlongs/Studio#247 |
I don't understand parts of this PR, but I unfortunately don't have enough time to dig into it either. Del is away for the weekend? If you're confident in these changes, go for it, @joanise otherwise my in-depth review would have to wait until next week |
Fair enough. I guess I'll test more, to make sure it really does work as I think it does, and decide what to do based on that. |
| if (textNode?.querySelector("body") == null) { | ||
| while (textNode?.hasChildNodes()) { | ||
| // @ts-ignore | ||
| body.appendChild(textNode.firstChild); | ||
| } | ||
| textNode.appendChild(body); | ||
| } | ||
| textNode?.appendChild(body); | ||
| } /**/ |
There was a problem hiding this comment.
I have to say I don't understand how this code works, but I tested it carefully, and what I can see is that it does work. I took a readalong, changed its body tag to something else in the base64-encoded .readalong file, and this code now correctly insert a new body tag in the right place. Whereas the old code did not, and causes trouble as we know.
* fix: cannot download other formats * fix: remove xmlns from tags Fixes #347
* fix: cannot download other formats * fix: remove xmlns from tags Fixes #347
* fix: cannot download other formats * fix: remove xmlns from tags Fixes #347
PR Goal?
bug fix
Fixes?
#347
Feedback sought?
sanity check
Priority?
high
Tests added?
to be added to studio test suites
How to test?
use the pr-preview editor to upload an offline format and try to export non web formats
Confidence?
Version change?
bug fix
This PR depends on the merging of PR ReadAlongs/Studio#247