Fix lint errors

ReToCode · Jul 10, 2024 · 3a7a8cf · 3a7a8cf
1 parent d134291
commit 3a7a8cf
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/openshift/ci-operator/generate-dockerfiles.sh b/openshift/ci-operator/generate-dockerfiles.sh
@@ -5,17 +5,18 @@ set -e
 function generate_dockerfiles() {
   local target_dir=$1; shift
   # Remove old images and re-generate, avoid stale images hanging around.
-  for img in $@; do
-    local image_base=$(basename $img)
+  for img in "$@"; do
+    local image_base
+    image_base=$(basename "$img")
     local kodata_path="$img/kodata"
-    mkdir -p $target_dir/$image_base
+    mkdir -p "$target_dir"/"$image_base"
     if [ -d "$kodata_path" ]
     then
-      bin=$image_base kodata_path=$kodata_path envsubst < openshift/ci-operator/Dockerfile_with_kodata.in > $target_dir/$image_base/Dockerfile
+      bin=$image_base kodata_path=$kodata_path envsubst < openshift/ci-operator/Dockerfile_with_kodata.in > "$target_dir"/"$image_base"/Dockerfile
     else
-      bin=$image_base envsubst < openshift/ci-operator/Dockerfile.in > $target_dir/$image_base/Dockerfile
+      bin=$image_base envsubst < openshift/ci-operator/Dockerfile.in > "$target_dir"/"$image_base"/Dockerfile
     fi
   done
 }
 
-generate_dockerfiles $@
+generate_dockerfiles "$@"