Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalized-path should return String, not File #32

Open
gardnermj opened this issue Nov 4, 2012 · 4 comments
Open

normalized-path should return String, not File #32

gardnermj opened this issue Nov 4, 2012 · 4 comments

Comments

@gardnermj
Copy link

normalized-path claims to return a path, but instead returns a File object.

@Raynes
Copy link
Owner

Raynes commented Nov 4, 2012

The rest of those functions that return File objects say the same thing. Is it the word 'path' tripping you up? If so, the documentation is all that needs to be changed.

@gardnermj
Copy link
Author

But absolute-path returns a String, doesn't it? That's why I assumed it was the implementation and not the docstring for normalized-path that needed fixing. Either way works for me, as long as things are consistent.

@Raynes
Copy link
Owner

Raynes commented Nov 4, 2012

Ah, yes, I see now. I think it should be returning a File. Good catch.

@egli
Copy link
Contributor

egli commented Sep 11, 2014

I think this has been fixed a long time ago (in 8fadbde)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants