Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel should trigger a channelSend event on sender #50

Open
shawncplus opened this issue Feb 13, 2019 · 1 comment · May be fixed by #76
Open

Channel should trigger a channelSend event on sender #50

shawncplus opened this issue Feb 13, 2019 · 1 comment · May be fixed by #76
Labels
active PR Issue has a open PR waiting for review/merge bug Something isn't working good first issue Good for newcomers
Milestone
3.1

Comments

@shawncplus
Copy link
Member

shawncplus commented Feb 13, 2019 •
edited
Loading

Channel right now on send triggers a channelReceive event on targets of the message but does not trigger any analogous event on the sender of the message. As such it's not possible at the moment to script for a player saying something if there are no targets
@shawncplus shawncplus added bug Something isn't working good first issue Good for newcomers labels Feb 13, 2019
@shawncplus
Copy link
Member Author

In addition to this a new config option should be added to Channel: boolean eventOnly (false). If eventOnly is true then channel should not use Broadcast to directly send messages instead only firing the appropriate events

@Sakeran Sakeran linked a pull request Apr 18, 2019 that will close this issue
Open
@shawncplus shawncplus added the active PR Issue has a open PR waiting for review/merge label Aug 22, 2019
@shawncplus shawncplus added this to the 3.1 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
active PR Issue has a open PR waiting for review/merge bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

Add eventOnly option, channelSend event to Channel class Sakeran/core
1 participant
@shawncplus