illumina review notes #16
Comments
|
can you please add a table of contents in the .Rmd file? they did mention
that in the call.
…On Mon, Mar 27, 2017 at 3:29 PM, Asif Zubair ***@***.***> wrote:
##General feedback##
- The app icons are inconsistent (Arkas are red, ATACSeeker is black).
I recommend using the red icon for all three, since you will only need to
change one.
- The developer names are inconsistent between the apps. All three
should have the same name, in the same format.
- The contact email should be added to the description of each app. I
recommend using a generic one ***@***.***) rather
than a specific individual.
- Privacy Policy is missing from all three apps. There is a link but
the page is blank.
- The “More info” link on each app leads to your lab’s github page.
This page is not super useful in the context of the apps…can you provide a
more specific link?
- The section headers in the descriptions are huge. Can you make them
a bit smaller?
- The Research Use Only statement needs to be prominently placed in
all three app descriptions. It is currently only present in Arkas RNA
Analysis
- The app version (1.0.0) should be stamped onto each output report.
ATACseeker feedback
- Needs a EULA.
- There should be a known limitations section that calls out the
requirement for BWA generated BAM files.
- App version when launched should be 1.0.0.
- The sentence “The input to the application are bam files produced by
the basespace bwa aligner .” should instead read “The input to the
application are bam files produced by the BWA Aligner App in BaseSpace
Sequence Hub.”
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFODSx4kr1ylM73MWZftt508-C8PBSV9ks5rqDhdgaJpZM4MgLz6>
.
|
|
the description also may need a link to your github account
On Thu, Mar 30, 2017 at 9:26 AM, Anthony Colombo <[email protected]
… wrote:
can you please add a table of contents in the .Rmd file? they did mention
that in the call.
On Mon, Mar 27, 2017 at 3:29 PM, Asif Zubair ***@***.***>
wrote:
> ##General feedback##
>
> - The app icons are inconsistent (Arkas are red, ATACSeeker is
> black). I recommend using the red icon for all three, since you will only
> need to change one.
> - The developer names are inconsistent between the apps. All three
> should have the same name, in the same format.
> - The contact email should be added to the description of each app. I
> recommend using a generic one ***@***.***) rather
> than a specific individual.
> - Privacy Policy is missing from all three apps. There is a link but
> the page is blank.
> - The “More info” link on each app leads to your lab’s github page.
> This page is not super useful in the context of the apps…can you provide a
> more specific link?
> - The section headers in the descriptions are huge. Can you make them
> a bit smaller?
> - The Research Use Only statement needs to be prominently placed in
> all three app descriptions. It is currently only present in Arkas RNA
> Analysis
> - The app version (1.0.0) should be stamped onto each output report.
>
> ATACseeker feedback
>
> - Needs a EULA.
> - There should be a known limitations section that calls out the
> requirement for BWA generated BAM files.
> - App version when launched should be 1.0.0.
> - The sentence “The input to the application are bam files produced
> by the basespace bwa aligner .” should instead read “The input to the
> application are bam files produced by the BWA Aligner App in BaseSpace
> Sequence Hub.”
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#16 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFODSx4kr1ylM73MWZftt508-C8PBSV9ks5rqDhdgaJpZM4MgLz6>
> .
>
|
|
Casey's notes:
|
|
Additionally:
|
|
congrats Asif. great stuff here. did you choose to leave the report as HTML? (IMHO this would be much better. who will dig through 30 pages of PDF?) |
|
you too, Anthony! Yes, I think a downloadable html file should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
General feedback
The app icons are inconsistent (Arkas are red, ATACSeeker is black). I recommend using the red icon for all three, since you will only need to change one.The developer names are inconsistent between the apps. All three should have the same name, in the same format.The contact email should be added to the description of each app. I recommend using a generic one ([email protected]) rather than a specific individual.Privacy Policy is missing from all three apps. There is a link but the page is blank.The “More info” link on each app leads to your lab’s github page. This page is not super useful in the context of the apps…can you provide a more specific link?The section headers in the descriptions are huge. Can you make them a bit smaller?The Research Use Only statement needs to be prominently placed in all three app descriptions. It is currently only present in Arkas RNA AnalysisATACseeker feedback
Needs a EULA.There should be a known limitations section that calls out the requirement for BWA generated BAM files.App version when launched should be 1.0.0.The sentence “The input to the application are bam files produced by the basespace bwa aligner .” should instead read “The input to the application are bam files produced by the BWA Aligner App in BaseSpace Sequence Hub.”The text was updated successfully, but these errors were encountered: