Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use external video player with "-" in the name #32

Closed
HasanAbbadi opened this issue Mar 10, 2021 · 1 comment
Closed

Can't use external video player with "-" in the name #32

HasanAbbadi opened this issue Mar 10, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@HasanAbbadi
Copy link

so, I was trying out different players to settle on one and keep watching with it.
I've tried mplayer and it worked like a charm, but the issue is that mplayer doesnt have a gui.

So i decided that I wanna use gnome-mplayer, and because the player is made out of two words that has a "-" in between
adl doesn't recognize it and it thinks that i am trying to type a command.

plz fix this soon
thx

@HasanAbbadi HasanAbbadi changed the title Can't use external video players that are two words Can't use external video player that has a long name Mar 10, 2021
@RaitaroH
Copy link
Owner

RaitaroH commented Apr 2, 2021

The - gets in the way of how adl handles input error. So, if the user doesn't provide arguments. Unfortunately gnome-mplayer simply breaks that logic. What I can tell you to do, and it's simple, is to make a symlink of gnome-mplayer to some folder in your path.
First find where gnome-mplayer is:

where gnome-mplayer

Then make a shortcut of it (without -) in some folder in your $PATH like so:

ln -s '/usr/bin/gnome-mplayer' ~/.local/bin/gnomeplayer

I can modify the code elsewhere, to allow counting episodes by mplayer, but... gnome-player doesn't output something useful in my case, just some glib errors. Can you use gnome-mplayer in a terminal and open something, then post here.

RaitaroH added a commit that referenced this issue Apr 2, 2021
@RaitaroH RaitaroH changed the title Can't use external video player that has a long name Can't use external video player with "-" in the name Apr 2, 2021
@RaitaroH RaitaroH added the wontfix This will not be worked on label Apr 2, 2021
@RaitaroH RaitaroH pinned this issue Jun 14, 2021
RaitaroH added a commit that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants