Added version checker for correct cb version #190 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs0109
commented
Jul 19, 2023
filip/clients/ngsi_v2/cb.py
Outdated
| option, which is implemented in FiLiP, but won't work with lower orion versions. | ||
| """ | ||
| orion_version = self.get_version()['orion']['version'] | ||
| if version.parse(orion_version) < version.parse('3.6.0'): |
There was a problem hiding this comment.
Maybe you can reused the code on L1200
filip/clients/ngsi_v2/cb.py
Outdated
| option, which is implemented in FiLiP, but won't work with lower orion versions. | ||
| """ | ||
| orion_version = self.get_version()['orion']['version'] | ||
| if version.parse(orion_version) < version.parse('3.6.0'): |
There was a problem hiding this comment.
I think some significant changes have also been made in 3.8.0. @tstorek Do you think we should also set an upper limit for the supported Orion version? like version < 3.8.0
There was a problem hiding this comment.
@djs0109 @jkriwet I think that it is worth having a look at the changes: https://github.com/telefonicaid/fiware-orion/releases. If introducing such bounds would also mean creating the issues to support the features in coming versions.
…on' into 190-Warn-about-wrong-orion-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #190