Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBOR encoding for the message_hello_t will need to be refactored. Space efficiency wise the CBOR container was structured like
[[int64_t (pub key len), int64_t (peer id len), bytes (pub key), bytes (peer id)]]
. Unfortunately this makes adding multiaddr information since we need to add a few things:with the addition of adding multiaddrs to this CBOR container, we will need to change to a format like so
[[int64_t (pub key len), bytes (pub key), int64_t (peer id len), bytes (peer id), int64_t (num addrs), int64_t (addr size), bytes (addr)]]
By doing this we will be able to determine the number of addrs to prepare for iteration, then advance over the CBOR container.