Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peerstore Updates (WIP) #56

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Peerstore Updates (WIP) #56

wants to merge 2 commits into from

Conversation

bonedaddy
Copy link
Contributor

CBOR encoding for the message_hello_t will need to be refactored. Space efficiency wise the CBOR container was structured like [[int64_t (pub key len), int64_t (peer id len), bytes (pub key), bytes (peer id)]]. Unfortunately this makes adding multiaddr information since we need to add a few things:

  • number of multiaddrs
  • for each multiaddr the size of the multiaddr
  • the actual bytes data

with the addition of adding multiaddrs to this CBOR container, we will need to change to a format like so

[[int64_t (pub key len), bytes (pub key), int64_t (peer id len), bytes (peer id), int64_t (num addrs), int64_t (addr size), bytes (addr)]]

By doing this we will be able to determine the number of addrs to prepare for iteration, then advance over the CBOR container.

@bonedaddy bonedaddy marked this pull request as draft November 12, 2020 08:13
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant