-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Renaming binaries / libraries #381
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaliffiAMD
force-pushed
the
rename-tool
branch
from
September 12, 2024 01:03
713ee86
to
2aaeb58
Compare
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
force-pushed
the
rename-tool
branch
from
September 13, 2024 21:26
088df98
to
3fcd2b3
Compare
Signed-off-by: David Galiffi <[email protected]>
Instead of using `$(which omnitrace)` use `$(which rocprof-sys-instrument)`, since the solo `omnitrace` binary has been deprecated.
Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
force-pushed
the
rename-tool
branch
from
September 23, 2024 19:10
1296bb2
to
49aa587
Compare
Signed-off-by: David Galiffi <[email protected]>
The ${PROJECT_NAME} is used throughout for output paths and as a token in templates. Using "rocprofsys" rather than "rocprof-sys" because the dash won't work for variable names (like: rocprofsys_DIR).
…ing is updated to use "rocprof-sys"
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
- For better consistency with file names. - Differential between "PROJECT_NAME:(rocprofsys): and "PACKAGE_NAME:(rocprof-sys)" - Fix install path the user-api header, they were still installing to `omnitrace`.
The file generated by rocprof-sys-avail -G was omnitrace-config. Now, it's rocprof-sys-config.
Moving the PR to new repository: ROCm/rocprofiler-systems#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Testing only.
DO NOT MERGE