Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reduce section for verify tests #3677

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Add reduce section for verify tests #3677

merged 3 commits into from
Dec 11, 2024

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Dec 4, 2024

This creates a new section in test_verify for reduce tests. All the reduce-like operators are added to this section including softmax, arg ops, layernorm, instancenorm, etc. We could also consider adding pooling to this section in the future as well.

@pfultz2 pfultz2 requested a review from causten as a code owner December 4, 2024 02:10
@pfultz2 pfultz2 requested review from CharlieL7 and shivadbhavsar and removed request for causten December 4, 2024 02:10
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (2e59073) to head (165eb81).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3677   +/-   ##
========================================
  Coverage    92.23%   92.23%           
========================================
  Files          514      514           
  Lines        21746    21746           
========================================
  Hits         20057    20057           
  Misses        1689     1689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfultz2 pfultz2 requested a review from kahmed10 December 4, 2024 15:48
@pfultz2 pfultz2 self-assigned this Dec 4, 2024
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
165eb8
Rate old
64fe0c
Diff Compare
torchvision-resnet50 64 3,256.14 3,254.94 0.04%
torchvision-resnet50_fp16 64 6,979.46 6,977.96 0.02%
torchvision-densenet121 32 2,434.85 2,436.55 -0.07%
torchvision-densenet121_fp16 32 4,101.52 4,076.26 0.62%
torchvision-inceptionv3 32 1,628.30 1,627.46 0.05%
torchvision-inceptionv3_fp16 32 2,745.77 2,741.58 0.15%
cadene-inceptionv4 16 765.36 764.31 0.14%
cadene-resnext64x4 16 813.69 813.14 0.07%
slim-mobilenet 64 7,462.46 7,466.83 -0.06%
slim-nasnetalarge 64 209.02 209.03 -0.01%
slim-resnet50v2 64 3,441.01 3,443.32 -0.07%
bert-mrpc-onnx 8 1,144.39 1,144.17 0.02%
bert-mrpc-tf 1 471.65 474.21 -0.54%
pytorch-examples-wlang-gru 1 422.04 416.53 1.32%
pytorch-examples-wlang-lstm 1 394.01 384.23 2.55%
torchvision-resnet50_1 1 775.58 783.29 -0.98%
cadene-dpn92_1 1 403.62 398.94 1.17%
cadene-resnext101_1 1 383.46 383.46 -0.00%
onnx-taau-downsample 1 345.59 345.52 0.02%
dlrm-criteoterabyte 1 33.35 33.33 0.08%
dlrm-criteoterabyte_fp16 1 52.73 52.73 -0.00%
agentmodel 1 8,187.33 8,127.83 0.73%
unet_fp16 2 58.89 58.89 0.01%
resnet50v1_fp16 1 934.85 938.63 -0.40%
resnet50v1_int8 1 1,027.04 984.73 4.30% 🔆
bert_base_cased_fp16 64 1,170.20 1,170.23 -0.00%
bert_large_uncased_fp16 32 363.35 362.94 0.11%
bert_large_fp16 1 200.23 200.28 -0.02%
distilgpt2_fp16 16 2,201.92 2,198.50 0.16%
yolov5s 1 541.97 531.33 2.00%
tinyllama 1 43.38 43.34 0.08%
vicuna-fastchat 1 176.75 172.03 2.74%
whisper-tiny-encoder 1 417.52 418.00 -0.11%
whisper-tiny-decoder 1 425.85 428.83 -0.69%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit 0860461 into develop Dec 11, 2024
43 of 45 checks passed
@causten causten deleted the verify-reduce-section branch December 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants