-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize Onnx parsing #3563
Open
bpickrel
wants to merge
4
commits into
develop
Choose a base branch
from
resize-parsing-update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Resize Onnx parsing #3563
+97
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpickrel
changed the title
Changed the way Resize Onnx parser iterates the args list
Resize Onnx parsing
Oct 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3563 +/- ##
===========================================
- Coverage 92.16% 92.14% -0.03%
===========================================
Files 512 512
Lines 21401 21422 +21
===========================================
+ Hits 19724 19739 +15
- Misses 1677 1683 +6 ☔ View full report in Codecov by Sentry. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic stepped through the args list in order, then assumed the first float-type input was the "Scales". This led to an error in an obscure case where the "ROIs" input, which is not supported by MigraphX, was not left empty and was thereby misinterpreted.
Changed logic to simply refer to the inputs by array reference; means we're allowed to assume that positional inputs all exist even if they're given as blank
''
quotes.Updated a few parsing tests to include correct blank positional inputs.
The reason for the older args parsing was apparently an effort to cover the fact that Resize requires one but not both of inputs
scales
andsizes
which are of different types, and someone thought that positional arguments could not be guaranteed.