-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception raised for quantization block-size = 1 in quark-generated int4 models. #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakhinderwalia
requested review from
CharlieL7 and
pfultz2
and removed request for
causten
October 5, 2024 16:43
lakhinderwalia
force-pushed
the
lw/block_quant_fix
branch
from
October 5, 2024 18:15
6e23d3a
to
0e7062b
Compare
lakhinderwalia
force-pushed
the
lw/block_quant_fix
branch
from
October 5, 2024 19:34
0e7062b
to
520ce0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3510 +/- ##
===========================================
+ Coverage 92.02% 92.05% +0.02%
===========================================
Files 509 509
Lines 21014 21014
===========================================
+ Hits 19339 19345 +6
+ Misses 1675 1669 -6 ☔ View full report in Codecov by Sentry. |
18 tasks
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
TedThemistokleous
added
roadmap
Tasks to finish for a release
bugfix
Fixes a bug found in the code.
INT4
labels
Oct 7, 2024
TedThemistokleous
approved these changes
Oct 7, 2024
pfultz2
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an exception that was raised while parsing for block quantization: block size = 1.
This corner case is raising an exception in quark-generated int-4 graphs.
A test case has been created to verify that no exception is raised, using a snippet off the quark generated model.
(Additionally, a test is being moved, based on a prior PR feedback. This test has nothing to do with this exception.)