Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Constant parsing to support more attributes #2141 #2216

Merged
merged 14 commits into from
Sep 20, 2023
Merged

Conversation

causten
Copy link
Collaborator

@causten causten commented Sep 20, 2023

Creating local PR from a fork. #2141 has all approvals needed to merge

For ONNX version 1.13 and above, certain tests failed due to lack of support for the aforementioned attributes.
After adding support, the same tests fail on account of CastLike being unsupported, so those tests are disabled until it is implemented.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2216 (d26707b) into develop (482e8d6) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head d26707b differs from pull request most recent head 4a96521. Consider uploading reports for the commit 4a96521 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2216   +/-   ##
========================================
  Coverage    91.49%   91.50%           
========================================
  Files          427      427           
  Lines        15953    15959    +6     
========================================
+ Hits         14596    14603    +7     
+ Misses        1357     1356    -1     
Files Changed Coverage Δ
src/onnx/parse_constant.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@causten causten merged commit a4957ab into develop Sep 20, 2023
15 of 16 checks passed
@causten causten deleted the fork_pr2141 branch September 20, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures due to IndexError: _Map_base::at
3 participants