-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Constant parsing to support more attributes #2141 #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and corresponding tests
umangyadav
approved these changes
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2216 +/- ##
========================================
Coverage 91.49% 91.50%
========================================
Files 427 427
Lines 15953 15959 +6
========================================
+ Hits 14596 14603 +7
+ Misses 1357 1356 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating local PR from a fork. #2141 has all approvals needed to merge
For ONNX version 1.13 and above, certain tests failed due to lack of support for the aforementioned attributes.
After adding support, the same tests fail on account of CastLike being unsupported, so those tests are disabled until it is implemented.