Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace build.image with build.os in the .readthedocs.yaml config #2209 #2215

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

causten
Copy link
Collaborator

@causten causten commented Sep 20, 2023

Cloning a PR from a fork locally...

https://docs.readthedocs.io/en/stable/config-file/v2.html

build.image (currently implicitly used) will be deprecated in October 2023

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2215 (af2d703) into develop (c54167c) will not change coverage.
The diff coverage is n/a.

❗ Current head af2d703 differs from pull request most recent head 99f7e27. Consider uploading reports for the commit 99f7e27 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2215   +/-   ##
========================================
  Coverage    91.53%   91.53%           
========================================
  Files          429      429           
  Lines        16011    16011           
========================================
  Hits         14655    14655           
  Misses        1356     1356           

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Sep 20, 2023

Test Batch Rate new
e9957c
Rate old
4a9652
Diff Compare
torchvision-resnet50 64 2,284.11 2,284.74 -0.03%
torchvision-resnet50_fp16 64 5,363.64 5,356.59 0.13%
torchvision-densenet121 32 1,829.52 1,840.31 -0.59%
torchvision-densenet121_fp16 32 3,392.06 3,389.09 0.09%
torchvision-inceptionv3 32 1,339.62 1,346.20 -0.49%
torchvision-inceptionv3_fp16 32 2,582.50 2,582.31 0.01%
cadene-inceptionv4 16 676.92 677.50 -0.09%
cadene-resnext64x4 16 590.86 590.01 0.15%
slim-mobilenet 64 7,216.92 7,212.07 0.07%
slim-nasnetalarge 64 237.02 236.46 0.24%
slim-resnet50v2 64 2,529.51 2,527.89 0.06%
bert-mrpc-onnx 8 721.16 721.22 -0.01%
bert-mrpc-tf 1 389.45 389.86 -0.11%
pytorch-examples-wlang-gru 1 300.77 301.54 -0.26%
pytorch-examples-wlang-lstm 1 309.81 311.98 -0.69%
torchvision-resnet50_1 1 557.98 553.11 0.88%
torchvision-inceptionv3_1 1 305.99 307.66 -0.54%
cadene-dpn92_1 1 348.53 345.86 0.77%
cadene-resnext101_1 1 220.22 220.10 0.05%
slim-vgg16_1 1 224.17 223.99 0.08%
slim-mobilenet_1 1 1,500.17 1,458.98 2.82%
slim-inceptionv4_1 1 219.34 222.45 -1.40%
onnx-taau-downsample 1 319.94 323.02 -0.96%
dlrm-criteoterabyte 1 21.71 21.70 0.05%
dlrm-criteoterabyte_fp16 1 40.62 40.56 0.15%
agentmodel 1 5,876.89 5,804.74 1.24%
unet_fp16 2 55.05 55.02 0.06%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten merged commit 434a06c into develop Sep 25, 2023
14 of 15 checks passed
@causten causten deleted the pr_2209 branch September 25, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants