Rectify flipped coordinate_transformation_mode logic in ROIAlign #2159

[causten]

This is a local PR (to get around dockerhub secrets problem) of 2159. It has already been approved
Resolves migraphx-benchmark#77

[migraphx-bot]

Test	Batch	Rate new eb15e1	Rate old 482e8d	Diff	Compare
torchvision-resnet50	64	2,283.78	2,285.72	-0.08%	✅
torchvision-resnet50_fp16	64	5,355.29	5,355.51	-0.00%	✅
torchvision-densenet121	32	1,836.83	1,841.73	-0.27%	✅
torchvision-densenet121_fp16	32	3,379.34	3,390.32	-0.32%	✅
torchvision-inceptionv3	32	1,348.98	1,337.79	0.84%	✅
torchvision-inceptionv3_fp16	32	2,584.88	2,590.65	-0.22%	✅
cadene-inceptionv4	16	682.40	681.03	0.20%	✅
cadene-resnext64x4	16	590.38	591.58	-0.20%	✅
slim-mobilenet	64	7,221.24	7,223.39	-0.03%	✅
slim-nasnetalarge	64	237.16	237.05	0.05%	✅
slim-resnet50v2	64	2,530.76	2,530.70	0.00%	✅
bert-mrpc-onnx	8	721.47	721.42	0.01%	✅
bert-mrpc-tf	1	389.69	389.60	0.02%	✅
pytorch-examples-wlang-gru	1	303.85	301.30	0.85%	✅
pytorch-examples-wlang-lstm	1	314.22	313.04	0.38%	✅
torchvision-resnet50_1	1	560.10	561.78	-0.30%	✅
torchvision-inceptionv3_1	1	308.04	308.04	0.00%	✅
cadene-dpn92_1	1	355.75	353.66	0.59%	✅
cadene-resnext101_1	1	220.55	220.48	0.03%	✅
slim-vgg16_1	1	224.74	224.47	0.12%	✅
slim-mobilenet_1	1	1,480.52	1,480.21	0.02%	✅
slim-inceptionv4_1	1	221.04	225.13	-1.82%	✅
onnx-taau-downsample	1	322.68	322.41	0.08%	✅
dlrm-criteoterabyte	1	21.68	21.69	-0.02%	✅
dlrm-criteoterabyte_fp16	1	40.65	40.65	0.01%	✅
agentmodel	1	5,904.83	5,884.85	0.34%	✅
unet_fp16	2	55.16	55.15	0.03%	✅

This build is OK for merge ✅

[migraphx-bot]

    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output

🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

[codecov]

Codecov Report

Merging #2214 (c80d17b) into develop (482e8d6) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head c80d17b differs from pull request most recent head 353190c. Consider uploading reports for the commit 353190c to get more accurate results

@@           Coverage Diff            @@
##           develop    #2214   +/-   ##
========================================
  Coverage    91.49%   91.50%           
========================================
  Files          427      427           
  Lines        15953    15959    +6     
========================================
+ Hits         14596    14603    +7     
+ Misses        1357     1356    -1     

Files Changed	Coverage Δ
src/include/migraphx/op/roialign.hpp	99.16% <100.00%> (ø)
src/onnx/parse_constant.cpp	100.00% <100.00%> (ø)
src/onnx/parse_roialign.cpp	92.30% <100.00%> (ø)

... and 1 file with indirect coverage changes