Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to verify --reduce #2206

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Improvements to verify --reduce #2206

merged 3 commits into from
Sep 22, 2023

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Sep 19, 2023

  • Skip verifying literals and parameters
  • Print the correct trim value
  • Print failure for an exception and continue reduce
  • Print if shapes do not match

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2206 (a6c1578) into develop (52eb36f) will not change coverage.
The diff coverage is n/a.

❗ Current head a6c1578 differs from pull request most recent head 2cb8344. Consider uploading reports for the commit 2cb8344 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2206   +/-   ##
========================================
  Coverage    91.51%   91.51%           
========================================
  Files          427      427           
  Lines        15972    15972           
========================================
  Hits         14616    14616           
  Misses        1356     1356           

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
6aa893
Rate old
c2e01b
Diff Compare
torchvision-resnet50 64 2,281.16 2,284.87 -0.16%
torchvision-resnet50_fp16 64 5,319.86 5,357.62 -0.70%
torchvision-densenet121 32 1,826.14 1,829.81 -0.20%
torchvision-densenet121_fp16 32 3,311.40 3,378.73 -1.99%
torchvision-inceptionv3 32 1,344.50 1,335.78 0.65%
torchvision-inceptionv3_fp16 32 2,504.74 2,585.25 -3.11% 🔴
cadene-inceptionv4 16 677.86 679.39 -0.23%
cadene-resnext64x4 16 590.46 590.19 0.05%
slim-mobilenet 64 7,224.22 7,216.76 0.10%
slim-nasnetalarge 64 236.98 236.57 0.17%
slim-resnet50v2 64 2,529.18 2,530.71 -0.06%
bert-mrpc-onnx 8 721.04 721.25 -0.03%
bert-mrpc-tf 1 390.42 391.28 -0.22%
pytorch-examples-wlang-gru 1 306.73 303.90 0.93%
pytorch-examples-wlang-lstm 1 312.90 311.77 0.36%
torchvision-resnet50_1 1 559.21 555.70 0.63%
torchvision-inceptionv3_1 1 308.02 306.97 0.34%
cadene-dpn92_1 1 351.80 351.70 0.03%
cadene-resnext101_1 1 220.51 220.52 -0.00%
slim-vgg16_1 1 224.24 224.37 -0.06%
slim-mobilenet_1 1 1,473.65 1,468.80 0.33%
slim-inceptionv4_1 1 222.28 221.26 0.46%
onnx-taau-downsample 1 323.17 322.42 0.23%
dlrm-criteoterabyte 1 21.71 21.67 0.17%
dlrm-criteoterabyte_fp16 1 40.65 40.54 0.26%
agentmodel 1 5,814.80 5,779.11 0.62%
unet_fp16 2 55.12 55.07 0.08%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten requested review from CharlieL7 and removed request for kahmed10 September 21, 2023 18:17
@causten causten merged commit 8298423 into develop Sep 22, 2023
14 of 15 checks passed
@causten causten deleted the verify-skip-literals branch September 22, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants