Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'memoryType' to 'type' #2139

Merged
merged 4 commits into from
Sep 6, 2023
Merged

rename 'memoryType' to 'type' #2139

merged 4 commits into from
Sep 6, 2023

Conversation

kahmed10
Copy link
Collaborator

hipPointerAttribute_t has a renamed the enum memoryType to type starting from ROCm 5.5. There is still backwards compatibility in current releases, but this is to use the new enum name.

@kahmed10 kahmed10 self-assigned this Aug 31, 2023
@kahmed10 kahmed10 added the simple small or simple changes label Aug 31, 2023
@kahmed10 kahmed10 requested review from pfultz2 and ahsan-ca August 31, 2023 02:34
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2139 (f0dad37) into develop (1403517) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head f0dad37 differs from pull request most recent head 9571184. Consider uploading reports for the commit 9571184 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2139   +/-   ##
========================================
  Coverage    91.43%   91.43%           
========================================
  Files          422      422           
  Lines        15771    15771           
========================================
  Hits         14420    14420           
  Misses        1351     1351           
Files Changed Coverage Δ
src/simplify_algebra.cpp 96.79% <100.00%> (ø)

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Aug 31, 2023

Test Batch Rate new
957118
Rate old
09f35e
Diff Compare
torchvision-resnet50 64 2,283.13 2,282.83 0.01%
torchvision-resnet50_fp16 64 5,359.28 5,362.69 -0.06%
torchvision-densenet121 32 1,827.52 1,837.46 -0.54%
torchvision-densenet121_fp16 32 3,392.12 3,390.99 0.03%
torchvision-inceptionv3 32 1,347.40 1,342.27 0.38%
torchvision-inceptionv3_fp16 32 2,584.84 2,592.18 -0.28%
cadene-inceptionv4 16 678.15 680.23 -0.31%
cadene-resnext64x4 16 589.86 590.35 -0.08%
slim-mobilenet 64 7,220.91 7,213.16 0.11%
slim-nasnetalarge 64 236.92 236.67 0.11%
slim-resnet50v2 64 2,525.34 2,527.47 -0.08%
bert-mrpc-onnx 8 720.49 720.61 -0.02%
bert-mrpc-tf 1 388.91 390.69 -0.45%
pytorch-examples-wlang-gru 1 301.91 302.21 -0.10%
pytorch-examples-wlang-lstm 1 312.79 305.98 2.23%
torchvision-resnet50_1 1 554.15 557.35 -0.57%
torchvision-inceptionv3_1 1 308.48 306.45 0.66%
cadene-dpn92_1 1 350.99 351.99 -0.28%
cadene-resnext101_1 1 220.00 220.90 -0.41%
slim-vgg16_1 1 224.35 224.23 0.05%
slim-mobilenet_1 1 1,469.24 1,476.56 -0.50%
slim-inceptionv4_1 1 222.14 223.35 -0.54%
onnx-taau-downsample 1 248.02 247.37 0.26%
dlrm-criteoterabyte 1 21.67 21.67 0.00%
dlrm-criteoterabyte_fp16 1 40.61 40.63 -0.03%
agentmodel 1 5,828.29 5,820.04 0.14%
unet_fp16 2 55.03 55.06 -0.07%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Aug 31, 2023


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten merged commit d4cfdb3 into develop Sep 6, 2023
12 checks passed
@causten causten deleted the hip_attr_type branch September 6, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants