Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sles docker to rocm5.6 #2133

Merged
merged 4 commits into from
Aug 31, 2023
Merged

update sles docker to rocm5.6 #2133

merged 4 commits into from
Aug 31, 2023

Conversation

causten
Copy link
Collaborator

@causten causten commented Aug 30, 2023

Moved SLES docker to a working 5.6 version of rocm

@causten causten requested review from pfultz2 and kahmed10 August 30, 2023 00:17
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2133 (6252dc8) into develop (d2486dc) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 6252dc8 differs from pull request most recent head bf89aea. Consider uploading reports for the commit bf89aea to get more accurate results

@@           Coverage Diff            @@
##           develop    #2133   +/-   ##
========================================
  Coverage    91.43%   91.43%           
========================================
  Files          422      422           
  Lines        15771    15771           
========================================
  Hits         14420    14420           
  Misses        1351     1351           

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Aug 30, 2023

Test Batch Rate new
bf89ae
Rate old
d2486d
Diff Compare
torchvision-resnet50 64 2,280.42 2,281.44 -0.04%
torchvision-resnet50_fp16 64 5,365.44 5,360.76 0.09%
torchvision-densenet121 32 1,837.81 1,837.13 0.04%
torchvision-densenet121_fp16 32 3,384.17 3,392.31 -0.24%
torchvision-inceptionv3 32 1,345.21 1,341.07 0.31%
torchvision-inceptionv3_fp16 32 2,576.26 2,585.78 -0.37%
cadene-inceptionv4 16 679.11 680.10 -0.14%
cadene-resnext64x4 16 589.04 591.09 -0.35%
slim-mobilenet 64 7,216.98 7,219.59 -0.04%
slim-nasnetalarge 64 236.95 236.76 0.08%
slim-resnet50v2 64 2,527.01 2,526.19 0.03%
bert-mrpc-onnx 8 720.59 720.32 0.04%
bert-mrpc-tf 1 390.85 390.05 0.21%
pytorch-examples-wlang-gru 1 300.85 303.94 -1.02%
pytorch-examples-wlang-lstm 1 314.59 310.46 1.33%
torchvision-resnet50_1 1 558.98 559.63 -0.12%
torchvision-inceptionv3_1 1 306.30 307.77 -0.48%
cadene-dpn92_1 1 359.44 349.41 2.87%
cadene-resnext101_1 1 220.10 220.45 -0.16%
slim-vgg16_1 1 224.10 224.41 -0.14%
slim-mobilenet_1 1 1,497.25 1,471.77 1.73%
slim-inceptionv4_1 1 220.69 220.62 0.03%
onnx-taau-downsample 1 247.68 247.77 -0.04%
dlrm-criteoterabyte 1 21.67 21.66 0.01%
dlrm-criteoterabyte_fp16 1 40.53 40.64 -0.26%
agentmodel 1 5,900.33 5,846.69 0.92%
unet_fp16 2 55.07 55.09 -0.03%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten self-assigned this Aug 30, 2023

#addition of repos for packages
RUN OPENSUSE_REPO=https://download.opensuse.org/repositories && \
zypper addrepo ${OPENSUSE_REPO}/science/SLE_15_SP4/science.repo && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this is used for ?

When i go to the link, It says :
name=Software for Scientists and Engineers (SLE_15_SP4)

But not sure what it is for ?

Copy link
Collaborator Author

@causten causten Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stole the text from the DevOps team. It does appear I really only need "devel:languages:perl.repo"
This happens because of...
Problem: nothing provides 'perl-File-BaseDir' needed by the to be installed hipcc-1.0.0.50600-sles154.67.x86_64

zypper addrepo ${OPENSUSE_REPO}/server:/http/15.4/server:http.repo && \
zypper addrepo ${OPENSUSE_REPO}/devel:/languages:/perl/SLE_15_SP4/devel:languages:perl.repo && \
zypper addrepo ${OPENSUSE_REPO}/devel:/tools/15.4/devel:tools.repo && \
zypper addrepo ${OPENSUSE_REPO}/multimedia:/libs/15.4/multimedia:libs.repo
Copy link
Collaborator

@pfultz2 pfultz2 Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where in the rocm documentation do we have these repos documented? Or where did you find these repos?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevOps team's SLES docker needed to resolve our ./install_prereqs.sh file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the lines that are not needed

@causten causten requested a review from pfultz2 August 31, 2023 15:23
@causten causten merged commit ac96370 into develop Aug 31, 2023
12 checks passed
@causten causten deleted the update_sles branch August 31, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants