-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ref tests under a separate directory and split them based on the type of operation #2106
Conversation
42a4413
to
8b74613
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2106 +/- ##
========================================
Coverage 91.43% 91.43%
========================================
Files 422 422
Lines 15771 15771
========================================
Hits 14420 14420
Misses 1351 1351 |
This build is not recommended to merge 🔴 |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output |
645e4b3
to
0761a09
Compare
Move ref tests from test to ref directory
c4fe9d2
to
323d9be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix CI checks. Otherwise LGTM
test/ref/CMakeLists.txt
Outdated
|
||
file(GLOB VERIFY_REF CONFIGURE_DEPENDS *.cpp) | ||
|
||
add_executable(test_ref ${VERIFY_REF}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use add_test_executable
, otherwise the tests wont be run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. I have made the change to use add_test_executable
.
add_dependencies(tests test_ref) | ||
add_dependencies(check test_ref) | ||
target_link_libraries(test_ref migraphx migraphx_onnx migraphx_ref) | ||
target_include_directories(test_ref PUBLIC ../include) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of these lines should already be handles by add_test_executable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to use add_test_executable
but without target_include_directories(test_ref PUBLIC ../include)
, it complains that it could not find test.hpp
. So I have kept target_include_directories(test_ref PUBLIC ../include)
.
This PR re-organizes ref tests. The following ref tests under the
test directory are moved to a separate ref directory under test:
ref_dot_op_test.cpp
ref_loop_test.cpp
ref_ops_nonstd_shape_test.cpp
ref_ops_test.cpp
ref_rnn_ops_test.cpp
Following changes are made to ref tests:
Tests have been stripped from ref_ops_test.cpp and
ref_ops_nonstd_shape_test.cpp, and moved to separate
files based on the type of operation.
Other ref test files were renamed.
TEST_CASE blocks having multiple tests have been broken down to have a single test for each TEST_CASE block.
All the tests under ref are compiled to a single executable.