Code

Modify reshapes #2099

Code

Merged

causten merged 61 commits intodevelopROCm/AMDMIGraphX:developfrom modify_reshapes_developROCm/AMDMIGraphX:modify_reshapes_developCopy head branch name to clipboardSep 27, 2023

+632-54

Commits

Commits on Aug 17, 2023

• Add reshape_lazy.hpp to perform aliasing

  Show description for 612ad42
  TedThemistokleous

  committed
  612ad42

• Add reshape lazy to arguments

  TedThemistokleous

  committed
  979d205

• Simplify reshape now that we assume reshape_lazy to perform aliasing

  Show description for 71e3023
  TedThemistokleous

  committed
  71e3023

• Remove can_strides_merge from reshape

  TedThemistokleous

  committed
  86ec62c

• Always add contiguous to reshapes

  Show description for 9d55b0f
  TedThemistokleous

  committed
  9d55b0f

• Add matcher for reshape_alias

  Show description for a6cfcff
  TedThemistokleous

  committed
  a6cfcff

• auto_contiguous always add contiguous after reshapes

  Show description for 17a0e9d
  TedThemistokleous

  committed
  17a0e9d

• Backup of changes.

  Show description for f75d0fd
  TedThemistokleous

  committed
  f75d0fd

• Add copy in reshape to make reshape by default perform a copy

  TedThemistokleous

  committed
  7cff9cf

• Remove auto contiguous for reshape.

  Show description for c7ed62c
  TedThemistokleous

  committed
  c7ed62c

• Remove contiguous being added with onnx/tf parsing of reshape()

  Show description for cea2f20
  TedThemistokleous

  committed
  cea2f20

• Work in progress. Getting segfaults now with eval

  TedThemistokleous

  committed
  a6565c8

• Update lowering and reshape to work for reshape_copy

  Show description for 717f733
  TedThemistokleous

  committed
  717f733

• Add reshape lazy after contiguous branch for try/catch in lowering.

  TedThemistokleous

  committed
  7527b13

Commits on Aug 18, 2023

• Remove contiguous from auto_contiguous_test

  Show description for 67e7842
  TedThemistokleous

  committed
  67e7842

• Add test for reshape_lazy

  Show description for de2040b
  TedThemistokleous

  committed
  de2040b

• Update op_shape_test for reshape->reshape_lazy rename

  Show description for f2eee04
  TedThemistokleous

  committed
  f2eee04

• Update rewrite_pooling_test for reshape->reshape_lazy

  TedThemistokleous

  committed
  81a679a

• Replace reshape with reshape_lazy in simplify_qdq_test

  TedThemistokleous

  committed
  5c1b156

• Update ref_ops_test with reshape->reshape_lazy

  TedThemistokleous

  committed
  e7ce5fa

Commits on Aug 24, 2023

• remove reshape_lazy from argument

  Show description for f744bf9
  TedThemistokleous

  committed
  f744bf9

• Set gather_elements to use aliased reshape instead of copy reshape

  Show description for 6039e18
  TedThemistokleous

  committed
  6039e18

• Fix resize/upsample ops to use reshape_lazy

  Show description for ee84972
  TedThemistokleous

  committed
  ee84972

• Fix rewrite_pooling_test to include reshape_lazy

  Show description for 4780ef8
  TedThemistokleous

  committed
  4780ef8

• Fix spacetodeath and depth to space ops for reshape lazy

  Show description for c2bf3e9
  TedThemistokleous

  committed
  c2bf3e9

Commits on Aug 25, 2023

• Cleanup unused reshaper_op_names()

  Show description for c14598f
  TedThemistokleous

  committed
  c14598f

• Refactor Reshape

  Show description for ac300ab
  TedThemistokleous

  committed
  ac300ab

• Remove Try-catch for reshape_lazy in lowering

  Show description for 20fa6c9
  TedThemistokleous

  committed
  20fa6c9

• Revert "Fix spacetodeath and depth to space ops for reshape lazy"

  Show description for 7d37922
  TedThemistokleous

  committed
  7d37922

• Revert "Fix resize/upsample ops to use reshape_lazy"

  Show description for 75c6fec
  TedThemistokleous

  committed
  75c6fec

• Revert "Set gather_elements to use aliased reshape instead of copy reshape"

  Show description for e9bcc23
  TedThemistokleous

  committed
  e9bcc23

• Revert "Replace reshape with reshape_lazy in simplify_qdq_test"

  Show description for 3916377
  TedThemistokleous

  committed
  3916377

• Add reshape tests into ref_ops_test

  Show description for a727dbb
  TedThemistokleous

  committed
  a727dbb

Commits on Aug 26, 2023

• Fix #define guard for MIGRAPHX_GUARD_OPERATORS_RESHAPE_LAZY

  Show description for dcac528
  TedThemistokleous

  committed
  dcac528

• clang-Tidy & clang-format cleanup

  TedThemistokleous

  committed
  628580f

Commits on Aug 28, 2023

• Change comment in reshape MIGRAPHX_THROW

  Show description for 8a0aeed
  

  TedThemistokleous

  and

  umangyadav

  authored
  8a0aeed

Commits on Sep 8, 2023

• Review updates; add contiguous before and after reshape

  CharlieL7

  committed
  65ffb72

Commits on Sep 11, 2023

• Merge branch 'develop' of github.com:ROCmSoftwarePlatform/AMDMIGraphX into modify_reshapes_develop

  CharlieL7

  committed
  7b46693

• Fix insert instruction

  CharlieL7

  committed
  2a8407a

• add comment

  CharlieL7

  committed
  b84ca27

• Add back ref_ops tests for reshape

  CharlieL7

  committed
  73910d0

• change return to the last contiguous

  CharlieL7

  committed
  949d46b

Commits on Sep 12, 2023

• Merge branch 'develop' into modify_reshapes_develop

  TedThemistokleous

  authored
  20a59c6

Commits on Sep 13, 2023

• Fix Format

  TedThemistokleous

  committed
  e917c77

Commits on Sep 14, 2023

• Add reshape tests back into op_shape_test

  Show description for 995f238
  TedThemistokleous

  committed
  995f238

Commits on Sep 19, 2023

• Remove extra find_reshape_cont{}

  TedThemistokleous

  committed
  19461d3

• Fix how reshape_lazy and contiguous blocks replace reshape operator.

  TedThemistokleous

  committed
  af99bec

Commits on Sep 20, 2023

• Fix input to lazy reshape to be from contiguous before.

  TedThemistokleous

  committed
  6d19c16

• Add back assertions for reshape and fix tests

  Show description for b4bdb71
  TedThemistokleous

  committed
  b4bdb71

• fixup! Fix input to lazy reshape to be from contiguous before.

  TedThemistokleous

  committed
  fece843

• Add reshape_dims() into reshape

  Show description for 0a92928
  TedThemistokleous

  committed
  0a92928

• Add test to verify modifying memory correctly via the copy for reshape

  Show description for aaa76f9
  TedThemistokleous

  committed
  aaa76f9

• fixup! Add reshape_dims() into reshape

  TedThemistokleous

  committed
  f820966

• [license] Update date in lowering.cpp

  TedThemistokleous

  committed
  31d3055

• Fix format for reshape.hpp

  TedThemistokleous

  committed
  bf31df9

• Change assert condition in reshape.hpp to >= instead of ==

  Show description for 75407f9
  TedThemistokleous

  committed
  75407f9

Commits on Sep 22, 2023

• Fix comment in reshape

  TedThemistokleous

  committed
  1a84aa2

• Change shape on reshape_broadcast_squeeze_memlayout_change in op_shape_test

  Show description for df9b7c0
  TedThemistokleous

  committed
  df9b7c0

• Remove size assert since outputs can change mem layout with nonstandard shapes

  TedThemistokleous

  committed
  0625bb8

Commits on Sep 26, 2023

• Merge branch 'develop' into modify_reshapes_develop

  causten

  authored
  35b67f7

Commits on Sep 27, 2023

• Merge branch 'develop' into modify_reshapes_develop

  causten

  authored
  bed80c2