Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup contiguous from Reshape parsing #2187

Closed
TedThemistokleous opened this issue Sep 14, 2023 · 2 comments · Fixed by #2190
Closed

Cleanup contiguous from Reshape parsing #2187

TedThemistokleous opened this issue Sep 14, 2023 · 2 comments · Fixed by #2190
Assignees
@TedThemistokleous
Labels
roadmap Tasks to finish for a release

Comments

@TedThemistokleous
Copy link
Collaborator

Addendum to PR #2099

since reshapes are being converted during lowering to lazy_reshape, and eliminate contiguous is used after to handle aliased/non aliased cases, we should remove the additional contiguous added when parsing in the reshape operator.
@TedThemistokleous TedThemistokleous self-assigned this Sep 14, 2023
@TedThemistokleous TedThemistokleous added the roadmap Tasks to finish for a release label Sep 14, 2023
@TedThemistokleous TedThemistokleous linked a pull request Sep 14, 2023 that will close this issue
Remove contiguous from reshape parsing #2190
Merged
@TedThemistokleous
Copy link
Collaborator Author

Just needs review

@TedThemistokleous
Copy link
Collaborator Author

Awaiting reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedThemistokleous TedThemistokleous

Labels
roadmap Tasks to finish for a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove contiguous from reshape parsing ROCm/AMDMIGraphX
1 participant
@TedThemistokleous