Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reshape_copy operator #1677

Closed
umangyadav opened this issue Apr 10, 2023 · 2 comments · Fixed by #2099
Closed

Add reshape_copy operator #1677

umangyadav opened this issue Apr 10, 2023 · 2 comments · Fixed by #2099
Assignees
@TedThemistokleous
Labels
bugfix Fixes a bug found in the code.

Comments

@umangyadav
Copy link
Member

umangyadav commented Apr 10, 2023 •
edited
Loading

Currently reshape operator requires standard shape inputs only. Reshape operator currently aliases input.

Add reshape operator that copies instead of aliases.

This would resolve many of the bugs encountered in simplify_algebra, for example this one: #1666
@shivadbhavsar shivadbhavsar mentioned this issue Apr 10, 2023
Closed
@TedThemistokleous TedThemistokleous self-assigned this Jun 27, 2023
@TedThemistokleous TedThemistokleous added the bugfix Fixes a bug found in the code. label Jun 27, 2023
@TedThemistokleous TedThemistokleous mentioned this issue Jun 27, 2023
Closed
@umangyadav
Copy link
Member Author

https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/1681/files should solve it for most cases.

@TedThemistokleous TedThemistokleous linked a pull request Aug 18, 2023 that will close this issue
Modify reshapes #2099
Merged
@TedThemistokleous
Copy link
Collaborator

In review. No more work required

@pfultz2 pfultz2 mentioned this issue Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedThemistokleous TedThemistokleous

Labels
bugfix Fixes a bug found in the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify reshapes ROCm/AMDMIGraphX
2 participants
@umangyadav @TedThemistokleous