Integrating generic_float struct for adding datatypes (#3522)

ROCm · Nov 8, 2024 · f5df004 · f5df004
1 parent 4b96e1c
commit f5df004
Show file tree

Hide file tree

Showing 10 changed files with 1,757 additions and 16 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -115,3 +115,5 @@ CheckOptions:
     value:           UPPER_CASE
   - key:             readability-identifier-naming.MacroDefinitionPrefix
     value:           MIGRAPHX_
+  - key:             readability-identifier-naming.ConstexprMethodIgnoredRegexp
+    value:           'quiet_NaN|signaling_NaN'
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -122,6 +122,7 @@ add_library(migraphx
 if(WIN32)
     # Due to compilation crashing, we need to use type-erased matchers on Windows.
     target_compile_definitions(migraphx PUBLIC MIGRAPHX_USE_TYPE_ERASED_MATCHERS=1)
+    target_compile_options(migraphx PUBLIC "-mno-ms-bitfields")
 endif()
 
 configure_file(version.h.in include/migraphx/version.h)

diff --git a/src/include/migraphx/bit_cast.hpp b/src/include/migraphx/bit_cast.hpp
@@ -25,6 +25,7 @@
 #if defined(__GNUC__) && !defined(__clang__)
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wstrict-aliasing"
+#pragma GCC diagnostic ignored "-Wduplicated-branches"
 #endif
 
 #include <migraphx/requires.hpp>