You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
join_ald_scenario is necessary to call prior to target_*. However, it pollutes summarize_* with unnecessary scenario columns, requiring either:
the user to manually group the remaining columns
the developer (me) to select the crucial columns and call distinct() prior to summarizing
1 puts a lot of onus on the user to know what they are doing (which i am skeptical of). 2 is a bit of a strict enforcement on our part... I propose we remove join_ald_scenario from the summarize_* helpfiles and regression tests, and assume the input has only lbk and ald columns, and suggest that the user use the ... argument to add further groups, in the case of inputs with multiple scenarios etc.
The text was updated successfully, but these errors were encountered:
join_ald_scenario
is necessary to call prior totarget_*
. However, it pollutessummarize_*
with unnecessary scenario columns, requiring either:distinct()
prior to summarizing1
puts a lot of onus on the user to know what they are doing (which i am skeptical of).2
is a bit of a strict enforcement on our part... I propose we removejoin_ald_scenario
from thesummarize_*
helpfiles and regression tests, and assume the input has only lbk and ald columns, and suggest that the user use the...
argument to add further groups, in the case of inputs with multiple scenarios etc.The text was updated successfully, but these errors were encountered: