Output names of target_* are not clear

[jdhoffa]

Feedback from a bank: the emission_factor_metric name "projected" is unclear.
I think it would be most helpful to have a coherent naming convention across methodology documents & code (and also aim to have the names similar between each type of target_* function).

May need some input from @2diiKlaus or others on the best way to do this.

See reprex below:

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(r2dii.data)
library(r2dii.match)
library(r2dii.analysis)

match_result <- match_name(loanbook_demo, ald_demo) %>%
  prioritize()

out_market_share <- match_result %>% 
  target_market_share(
    ald = r2dii.data::ald_demo,
    scenario = r2dii.data::scenario_demo_2020,
    region_isos = r2dii.data::region_isos_demo
  )
#> Joining, by = c("sector", "technology", "green_or_brown")

out_sda <- match_result %>%
  target_sda(
    ald = ald_demo,
    co2_intensity_scenario = co2_intensity_scenario_demo
  )

select(out_market_share,weighted_production_metric) %>% distinct()
#> # A tibble: 5 x 1
#>   weighted_production_metric  
#>   <chr>                       
#> 1 projected                   
#> 2 normalized_corporate_economy
#> 3 target_cps                  
#> 4 target_sds                  
#> 5 target_sps

select(out_sda, emission_factor_metric) %>% distinct()
#> # A tibble: 3 x 1
#>   emission_factor_metric
#>   <chr>                 
#> 1 projected             
#> 2 target                
#> 3 scenario_benchmark

^{Created on 2020-07-24 by the reprex package (v0.3.0)}

[maurolepore]

@jdhoffa, FYI I think the last line of your reprex is unintentionally broken: Where it says out you likely mean out_market_share.

[jdhoffa]

tnx mauro, fixed

[jdhoffa]

Relates to #105