Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you consider using GitHub for version control and changes tracking? #9

Open
eimix opened this issue Oct 3, 2019 · 5 comments

Comments

@eimix
Copy link

eimix commented Oct 3, 2019

Could you consider using GitHub for version control and changes tracking?

Now you use your own versionning 6.31 6.4 and so on, in this way could not see what changes were made.

Do you accept contribution to this project?

@baststar
Copy link

baststar commented Oct 29, 2019

Hi Phil,
i refactored your structure to work within platformio (same codebase as of 6.7)
would be nice if you can use this structure, working with platformio/vscode is much easier, easy lib-updates since they are included via platformio.ini etc...

have a look here:
https://github.com/baststar/mowercode

had to put all NodeMCU-Code into one file because of the Blynk-Library which instantiates "Blynk" within their library :/

@eimix
Copy link
Author

eimix commented Nov 5, 2019

Looks like most builders are happy with Arduino.
Is it possible to use same "fork" for Platformio and Arduino?

@baststar
Copy link

baststar commented Nov 5, 2019

For PlatformIO its required that you use cpp instead of .ino-Files. The codebases are not compatible. Ino-files are concated to one big file when the project is built in the ArduinoIDE (you need to import dependencies only once in the main file for example)

@eimix
Copy link
Author

eimix commented Nov 5, 2019

There is no coding comunity for this project - just builders :)
it would be great to have some fork/branch with many code contributors,
but if using Platformio - not all users could use it straight forward.

All Platformio users understand Arduino but not the other way :/

@baststar
Copy link

baststar commented Nov 5, 2019

yeah i understand, but its not so extremly different, just the structure. Its easier for new contributors with the platformio-structure, because you only need to clone the repository and can than just build it, without struggeling with libraries and other stuff. They are defined in the platformio.ini-file per project (mega-project, nano-project, uno-project and nodemcu-project). With the config.h-files you can merge updates without overwriting your configuration etc.
The code itself - the syntax - is the same, i just outsourced some declarations and initialisations etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants