Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wildcard based topic configurations #328

Open
yatharthranjan opened this issue Feb 6, 2023 · 0 comments
Open

Add support for wildcard based topic configurations #328

yatharthranjan opened this issue Feb 6, 2023 · 0 comments
Labels
feature roadmap Item on the RADAR-base roadmap

Comments

@yatharthranjan
Copy link
Member

From @blootsvoets

There would be some code modification needed to use wildcards, because the current config is also prescriptive: if a topic does not yet exist in any specification, adding the topic to the config will cause it to be created. If you modify the code, it would be possible, not with a full regex but a wildcard, e.g. empatica_, ?mpatica_. You could add a property isWildcard that automatically gets set to yes if a * or ? is detected.
On line
https://github.com/RADAR-base/RADAR-Schemas/blob/45d8c8ae4ddb997966b8ef9d98d98b8be[…]/src/main/java/org/radarbase/schema/registration/KafkaTopics.kt
you would need to exclude any wildcards. And any references to toolConfig.topics[t] in KafkaTopics needs to be changed to findTopicConfig(t) where findTopicConfig does a wildcard match. Also, you would have to check the rest of the code if the literal name of the topic is used. This is the case at least in SchemaRegistry in the same directory.

@yatharthranjan yatharthranjan added feature roadmap Item on the RADAR-base roadmap labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature roadmap Item on the RADAR-base roadmap
Projects
Status: No status
Development

No branches or pull requests

1 participant