Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean type #312

Open
afolarin opened this issue Sep 10, 2022 · 1 comment
Open

Boolean type #312

afolarin opened this issue Sep 10, 2022 · 1 comment

Comments

@afolarin
Copy link
Member

Quick question:

An Issue arose with merging the pyspark dataframes. It is related to the boolean/string issue we faced while reading from the schema. The reason for the inconsistency was that in some schema, the datatype is defined as:
'type': 'boolean'
While for some others, it is defined as:

'type': {
    'type': 'boolean'
}

@blootsvoets any reason for this and would it make sense to try validating for a consistent form?

cc/ @thepushkarp @Hsankesara

@blootsvoets
Copy link
Member

Indeed simple types should not be nested like that. It’s only used for complex types: lists, maps, enums and records. If the schema compiles (does it?) it is hard to check this programmatically, because in the compiled schema you cannot distinguish these notations.

Feel free to add an entry to the readme and/or pyspark Github actions test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants