Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate whether raw data can be sent with the REST API schemas #29

Open
blootsvoets opened this issue May 30, 2017 · 0 comments
Open

Comments

@blootsvoets
Copy link
Member

The REST API now uses generic names like Dataset and header but assumes that all data will be aggregated and from a sensor. To support raw data and questionnaires as well, we should look which fields could be nullable or generalised.

As per @fnobilia:

To use this header with raw data, I would suggest to make descriptiveStatistic and timeFrame nullable. But to return raw data using Dataset, the Item schema has to support all raw data schemas and startDateTime can be nullable. Just to make it clearer

{
  "namespace": "org.radarcns.avro.restapi.dataset",
  "type": "record",
  "name": "Item",
  "doc": "Dataset item. It contains a value and its related time.",
  "fields": [
    {"name": "sample", "type": [
      "org.radarcns.avro.restapi.data.DoubleSample" ,
      "org.radarcns.avro.restapi.data.Acceleration",
      "org.radarcns.empatica.EmpaticaE4Acceleration",
      "org.radarcns.biovotion.BiovotionVSMAcceleration",
      "..."
      ], "doc": "..." } ,
    {"name": "startDateTime", "type": ["null", "string"], "doc": "...", "default": null}
  ]
}

[...] This change implies some changes also in the REST-Api project to return JSON

This would also affect the header org.radarcns.avro.restapi.header.Header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant