1741 group multiple delete create notification requests into a single request #1744
+86
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the dedicated endpoint in appserver.
mpgxvii
reviewed
Jul 11, 2024
| return this.appServerService.addNotificationsBundle(notifications, subjectId, projectId) | ||
| .then((resultNotification: FcmNotificationDto) => { | ||
| this.setLastNotificationUpdate(Date.now()) | ||
| // notification.notification.id = resultNotification.id |
There was a problem hiding this comment.
Would it be possible to still store back the notification id? We would still need it when we want to cancel reminders/future notifications for a task once it has been completed.
There was a problem hiding this comment.
That would be done bij uncommenting the lines below right?
There was a problem hiding this comment.
No cause I think the request would return multiple notifications and each would be needed to get stored back to the task object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed RADAR-base/RADAR-Appserver#438 we reduce the number of requests by the aRMT application by multiple grouping create and delete notifications in one request.
fixes #1741