Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added terraform-docs for better documentation #28

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Dec 4, 2024

Added terraform-docs and some other small improvements.

@keyvaann keyvaann requested a review from baixiac December 4, 2024 22:07
Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to have dev formatting and TF module docs. Is that possible to add a description on how to install terraform-docs and run doc-gen to the top-level readme?


## Contributing

Make sure to install [terraform-docs](https://github.com/terraform-docs/terraform-docs) and run `make prepare` before making a commit to make sure the documentation is up to date and the code is valid.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baixiac There is a brief description about it here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, it slipped through somehow. Sounds like it would be a good use case for the git pre-commit hook?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it would be good for that but it needs extra configuration and documentation that I think we can do at a later time.

@keyvaann keyvaann merged commit a2a9da9 into main Dec 6, 2024
2 checks passed
@keyvaann keyvaann deleted the terraform-docs branch December 6, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants