Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to deploy K8s metrics server #19

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Add the option to deploy K8s metrics server #19

merged 3 commits into from
Jun 3, 2024

Conversation

baixiac
Copy link
Member

@baixiac baixiac commented May 31, 2024

This PR adds the option to deploy the Metrics Server and gives users read-only access to the Kubernetes Dashboard.

@baixiac baixiac requested a review from keyvaann May 31, 2024 11:14
@keyvaann
Copy link
Collaborator

Isn't it better to install these components via RADAR-Kuberentes?
Also I remember that there was better alternatives for Kubernetes Dashboard but I don't remember what they were.

@baixiac
Copy link
Member Author

baixiac commented Jun 3, 2024

Ye, not sure why metrics-server has not been included in RADAR-Kuberentes.

Also I remember that there was better alternatives for Kubernetes Dashboard but I don't remember what they were.

I saw people using Lens and Aptakube but am not familiar with their license and pricing plans. AWS console also provides a limited dashboard view and let's hope EKS can catch up with other competitors on UI improvement soon. This PR only creates an optional deployment (disabled by default) with the "native" k8s dashboard so shall we include both components as a minimum offer to users for now and remove them when RADAR-Kuberentes has a better solution?

keyvaann
keyvaann approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, LGTM

@baixiac baixiac merged commit c5e0580 into main Jun 3, 2024
2 checks passed
@baixiac baixiac deleted the metrics-server branch June 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyvaann keyvaann keyvaann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baixiac @keyvaann