[FIX] Fix libstdc++fs, latest FairRoot breaking changes and format cmake scripts #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanzhaoW
force-pushed
the
edwin_fix_cmake
branch
from
d03810a
to
69b5e5e
Compare
YanzhaoW
force-pushed
the
edwin_fix_cmake
branch
from
69b5e5e
to
0cde00d
Compare
|
@jose-luis-rs Ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
-lstdc++fsin r3bbase/CMakeLists.txt when macOS is used (due to an issue reported by @hapol). However the flag is still needed for gcc version less or equal to 8. The flag is also removed since gcc 9 (see the release note).padrecently (see here). Their usages in the root cmake file have been replaced byfair_pad.${VMCLIB}to a targetVMCLibraryChecklist:
devbranch