Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R3BDataMonitor, R3BValueError and Update on FileSource2 #1078

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

YanzhaoW
Copy link
Contributor

@YanzhaoW YanzhaoW commented Aug 23, 2024

Features

  • Adding a new class R3BDataMonitor, a histogram manager, that could be used inside a task class.
  • Adding a new class R3BValueError, a numeric data structure to represent physical values with errors. Popular operations, such as +, -, /, * are implemented.
  • Update on R3BFileSource2 such that it can read a root file just containing a root tree. (todo: need a test)

This pull request is second part of the PR #890 .


Checklist:

@YanzhaoW YanzhaoW marked this pull request as draft August 23, 2024 10:34
@YanzhaoW YanzhaoW changed the title R3BDataMonitor, R3BValueError and Update on FileSource2 [WIP] R3BDataMonitor, R3BValueError and Update on FileSource2 Aug 23, 2024
@YanzhaoW YanzhaoW marked this pull request as ready for review September 25, 2024 23:32
@YanzhaoW YanzhaoW changed the title [WIP] R3BDataMonitor, R3BValueError and Update on FileSource2 R3BDataMonitor, R3BValueError and Update on FileSource2 Sep 25, 2024
@YanzhaoW
Copy link
Contributor Author

@jose-luis-rs Ok, this is ready to be merged.

Adding new class R3BDataMonitor for easy histogram operations in
FairTask. New class ValueError can be used to represent values with
errors. R3BFileSource2 now can handle root files just with root tree
inside. Documentation of these new classes and changes have been added
to the README.md in the r3bbase folder.
@jose-luis-rs
Copy link
Contributor

Thanks

@jose-luis-rs jose-luis-rs merged commit 018e08a into R3BRootGroup:dev Oct 1, 2024
6 checks passed
@YanzhaoW YanzhaoW deleted the edwin_data_monitor branch November 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants