Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(views): toggle visibility #135 #136

Merged
merged 5 commits into from
Oct 21, 2023
Merged

feat(views): toggle visibility #135 #136

merged 5 commits into from
Oct 21, 2023

Conversation

R0tenur
Copy link
Owner

@R0tenur R0tenur commented Oct 20, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (eb38b5d) 81.90% compared to head (296469e) 89.34%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   81.90%   89.34%   +7.43%     
==========================================
  Files          16       16              
  Lines         210      244      +34     
  Branches       24       27       +3     
==========================================
+ Hits          172      218      +46     
+ Misses         33       21      -12     
  Partials        5        5              
Flag Coverage Δ
unittests 89.34% <85.52%> (+7.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
backend/src/repositories/mssql.repository.ts 95.83% <100.00%> (+1.71%) ⬆️
backend/src/services/builder.service.ts 97.36% <100.00%> (+0.07%) ⬆️
frontend/src/app/app.component.ts 100.00% <100.00%> (+50.00%) ⬆️
...tend/src/app/components/button/button.component.ts 100.00% <ø> (ø)
...ponents/mermaid-viewer/mermaid-viewer.component.ts 90.90% <100.00%> (ø)
frontend/src/app/services/data-studio.service.ts 86.36% <100.00%> (+6.87%) ⬆️
backend/src/message.handler.ts 96.15% <95.83%> (-3.85%) ⬇️
backend/src/services/export.service.ts 89.47% <88.88%> (+0.58%) ⬆️
backend/src/extension.ts 0.00% <0.00%> (ø)
backend/src/message.function.ts 55.55% <55.55%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@R0tenur R0tenur marked this pull request as ready for review October 21, 2023 21:01
@R0tenur R0tenur merged commit 2821ebd into master Oct 21, 2023
6 checks passed
@R0tenur R0tenur deleted the toggle-view-visibility branch October 21, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants