Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libpq to fix issue with RPostgres and Redshift #51

Closed
wants to merge 1 commit into from

Conversation

ilarischeinin
Copy link

Current CRAN Mac binaries of RPostgres are broken for (at least some instances of) Redshift (r-dbi/RPostgres#441). Compiling RPostgres from source against libpq/postgresql installed via Homebrew fixes the issue, so bumping the libpq dependency here should help.

I'm not an author of RPostgres, so tagging @krlmlr for more authority on this.

Right now I bumped the version number from 14.5 to 16.2, which is the newest version. (Newest libpq available on Homebrew, as well as newest postgresql available at the source).

In case it would be preferred to not bump major versions, brew install postgresql installs postgresql@14 and version 14.11 to be exact. Compiling RPostgres from source against that version works too, so bumping to 14.11 should also be adequate.

@krlmlr
Copy link

krlmlr commented Apr 18, 2024

Thanks, Ilari, for investigating.

@s-u: Is there a way to build binaries based on this PR, to see if they fix the underlying issue?

@jeroen
Copy link
Contributor

jeroen commented Apr 19, 2024

I think we'll also need to enable the gssapi dependency to enable authentication and the openssl dependency to enable secure connections. See the homebrew configuration for example.

However the current openssl in this recipes repo is too old (1.1 is end of life) so you would need to update that first.

@s-u
Copy link
Member

s-u commented Aug 6, 2024

@jeroen we have now openssl3 - would you care to update this (or a new PR) to match what you had in mind, please?

@jeroen
Copy link
Contributor

jeroen commented Aug 6, 2024

I got stuck on trying to build a static version of libkrb5. The version of krb5 included with MacOS $(krb5-config --libs) is ancient and leads to auth problems with postgres, so we would need a more recent version. However I couldn't get a static version of krb5 to build.

@s-u
Copy link
Member

s-u commented Aug 6, 2024

Jeroen, thanks. I had a quick look and Apple actually appears to use MITShim + Heimdal:

$ krb5-config --vendor
Apple MITKerberosShim

so switching to MIT Kerberos would entirely change the back-end. It would be nice to see what actually causes the issue and whether it is generally something with Heimdal, Apple's MITShim or just buggy RedShift.

Given that the latter is commercial and Amazon is recommending the use of ODBC instead, I'm inclined to close this as there is no way to actually reproduce this without some 3rd part service and the setup seems not appropriate since it's not the real target of the package. However, if anyone whats to give is a go, I'd be happy to re-open if there are any bright ideas.

@s-u s-u closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants