Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages-without-package-json - False positives #86

Open
Netail opened this issue Aug 11, 2024 · 3 comments
Open

packages-without-package-json - False positives #86

Netail opened this issue Aug 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Netail
Copy link

Netail commented Aug 11, 2024

Hello,
I am getting false-positive errors regarding the packages-without-package-json rule.

{
  "workspaces": [
    "apps/*",
    "packages/*",
    "packages/ui/external/*",
  ]
}

./apps/.npm/package.json doesn't exists; A folder created by NPM
./packages/ui/package.json doesn't exists; a sub-folder used by another workspaces glob, but does not contain source code itself

@QuiiBz QuiiBz added the bug Something isn't working label Aug 12, 2024
@QuiiBz
Copy link
Owner

QuiiBz commented Aug 12, 2024

This behavior is expected, as any folder in e.g. apps/* is considered a package. We could (and maybe should) ignore .npm folders though, and for packages/ui you should update your workspaces configuration to add !packages/ui

@Netail
Copy link
Author

Netail commented Aug 13, 2024

We could (and maybe should) ignore .npm folders though

I guess a set of predefined folders to ignore would work :)

Alright, add the exclude glob for the other one

@baptisteArno
Copy link
Contributor

Unfortunately adding !packages/folder in package.json workspaces, will make turborepo ignore all packages under packages/folder 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants