Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat?: --fix should run install command if fixing version missmatches #38

Closed
juliusmarminge opened this issue Nov 25, 2023 · 6 comments · Fixed by #71
Closed

feat?: --fix should run install command if fixing version missmatches #38

juliusmarminge opened this issue Nov 25, 2023 · 6 comments · Fixed by #71
Labels
enhancement New feature or request

Comments

@juliusmarminge
Copy link

when running --fix and fixing a version, I believe sherif should also run the install command for the package manager at use:

CleanShot 2023-11-25 at 18 16 12@2x

@QuiiBz QuiiBz added the enhancement New feature or request label Dec 25, 2023
@QuiiBz
Copy link
Owner

QuiiBz commented Dec 25, 2023

Forgot to reply to this, sorry. I'm not 100% convinced about automatically running <packageManager> install after autofixing. What if it fails to install, should Sherif revert the changes?

@Willem-Jaap
Copy link
Contributor

Maybe a prompt to let the user choose himself?

Would you like Sherif to run `pnpm install` (Y/n)

@thomasfr
Copy link

No please don’t run install. Which package manager should it use? And it also complicates the possibility to run fix in non-interactive mode as well #68

@QuiiBz
Copy link
Owner

QuiiBz commented Jun 29, 2024

We could add a --install flag that when used along --fix, also runs the install command of your package manager.

@thomasfr
Copy link

Ok, @QuiiBz you convinced me that it’s actually a good idea to run install afterwards to update the lockfile as well.

@QuiiBz
Copy link
Owner

QuiiBz commented Aug 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants