Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity checking tests no longer compile on 13.7.0 #1182

Closed
1 task done
stodirascu opened this issue Dec 13, 2024 · 2 comments · Fixed by #1183
Closed
1 task done

Identity checking tests no longer compile on 13.7.0 #1182

stodirascu opened this issue Dec 13, 2024 · 2 comments · Fixed by #1183

Comments

@stodirascu
Copy link

  • I have read CONTRIBUTING and have done my best to follow them.

Seems the current 13.7.0 made our tests stop building, namely due to these changes:

-public func be(_ expected: AnyObject?) -> Matcher<AnyObject> {
+public func be<T: AnyObject>(_ expected: T?) -> Matcher<T> {

We have a test checking whether a delegate (of a protocol type) is identical to an expected object:

protocol OurDelegate: AnyObject { }
...
var delegate: (any OurDelegate)?
...
expect(delegate).to(be(someObject))

which is a valid scenario imho.

@younata would it be possible to revert?

@younata
Copy link
Member

younata commented Dec 13, 2024

Thanks for catching this! I just put up #1183 to address. I'll release Nimble 13.7.1 with it later today.

@stodirascu
Copy link
Author

Thanks for that 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants