Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] store a unique hash to identify calculations #2409

Open
tomdemeyere opened this issue Aug 10, 2024 · 1 comment
Open

[Proposal] store a unique hash to identify calculations #2409

tomdemeyere opened this issue Aug 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tomdemeyere
Copy link
Contributor

tomdemeyere commented Aug 10, 2024

What new feature would you like to see?

This aim to implement a unique hash that could be used to identify calculations. The hash should depends on things like:

  1. The job being ran.
  2. Rounded attributes of the Atoms object.
  3. All the parameters used to run the calculations.

The hash would then be stored in the results dict. The idea is that users should be able to do things like this

@subflow
run_all_calculations(atoms_list):
    for atoms in atoms_list:
         if unique_hash(my_job, atoms, parameters) not in already_done:
              my_job(atoms, parameters)...

This is based on discussion from #2399

@tomdemeyere tomdemeyere added the enhancement New feature or request label Aug 10, 2024
@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Aug 10, 2024

I think this is an interesting idea (even though workflow tools often have similar hashing).

We already have hashing of the Atoms object. It would be possible to do the same for a collection of entries in the DB that define the job (e.g. parameters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants