Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm64 support for alpine #238

Open
lucas42 opened this issue Sep 4, 2024 · 3 comments · May be fixed by #240
Open

arm64 support for alpine #238

lucas42 opened this issue Sep 4, 2024 · 3 comments · May be fixed by #240

Comments

@lucas42
Copy link

lucas42 commented Sep 4, 2024

According to the README:

Sometimes there are upstream eclipse-temurin images based on Alpine Linux.

As of 2022-9-29 these are available for the linux/amd64 architecture only.

However, since that was written, it now appears that eclipse-temurin's image supports alpine on architecture linux/arm64/v8 for JDK versions 21 & 22.

Would it be possible for docker-clojure to support arm64 in instances where it's available upstream? Thanks!
@cap10morgan
Copy link
Collaborator

@lucas42 Thanks for letting us know about this! We can definitely add these to the build matrix.

@cap10morgan
Copy link
Collaborator

I'm working on this but it exposed a blind spot in our variant exclusion subsystem. Namely, it can't currently exclude an architecture from some JDK versions but not others. I'm going to see if I can teach it to do that while also consolidating & cleaning up some non-orthogonal code in that part of the build system.

But it will be a little longer in coming than I'd hoped.

@lucas42
Copy link
Author

lucas42 commented Sep 8, 2024

No problem! Thanks for taking a look.
I'd normally offer to do a pull request myself, but I'm brand new to clojure, so I worry in this case I'd do more harm than good.

@cap10morgan cap10morgan linked a pull request Sep 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: exclude architectures Quantisan/docker-clojure
2 participants
@cap10morgan @lucas42